Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 40 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ pnpm run dev:transpile # recompiles when you change .ts files
pnpm run dev:styles # recompiles when you change .scss files
```

#### Known issues
## Known issues

##### `yarn install` prints error 'Could not detect abi for version 30.0.6 and runtime electron'
### 1. `pnpm install` prints error 'Could not detect abi for version 30.0.6 and runtime electron'

`yarn install` may print an error like the following, but it can be ignored because the overall operation succeeds.
`pnpm install` may print an error like the following, but it can be ignored because the overall operation succeeds.

```
$ ./node_modules/.bin/electron-builder install-app-deps
Expand Down Expand Up @@ -115,6 +115,43 @@ $ ./node_modules/.bin/electron-builder install-app-deps
Node.js v20.11.1
```

### 2. Verifying via reCAPTCHA doesn't work if both Signal and Signal Beta clients installed when setting up as standalone

#### Steps to reproduce

1. Get told to verify by captcha
2. Complete captcha in Google Chrome
3. Dialog prompt will tell you to click to open in Signal app, but captcha doesn't complete properly

#### Steps to solve the issue

1. Enter phone number and click "Send SMS", (opens the captcha link in your browser)
2. Verify using the captcha
3. Once it is verified in the browser, you will get the "xdg-open" or "Open Signal" dialog prompt
4. Ignore the prompt
5. Right click on the "Open Signal" hyperlink below the verification box and copy the link address. You should see something with the format with the format of `signalcaptcha://signal-hcaptcha.Foo-bAr_baz.challenge.fOo-bAR_baZ.fOO-BaR_baz...`
6. In a terminal window type `pnpm start` space and then paste the link address from the previous step, ie.
`pnpm start signalcaptcha://signal-hcaptcha.Foo-bAr_baz.challenge.fOo-bAR_baZ.fOO-BaR_baz...`
7. This command will open the `signalcaptcha://...` url with the currently running development version of the app
8. Execute the command, it will say something like

```making app single instance
quitting; we are the second instance
Done in 0.67s.
```

9. You can now go back to the original terminal session where you first ran pnpm start, you should see something like

```
{"level":30,"time":"2024-01-28T08:07:14.558Z","msg":"challengeMain.onRequest(standalone registration): received challenge request, waiting for response"}
{"level":30,"time":"2024-01-28T08:07:40.974Z","msg":"handleSignalRoute: Matched signal route: captcha"}
{"level":30,"time":"2024-01-28T08:07:40.974Z","msg":"challengeMain.handleCaptcha: sending captcha response to 1 handlers"}
{"level":30,"time":"2024-01-28T08:07:40.975Z","msg":"challengeMain.onRequest(standalone registration): got response after 26415ms"}
```

This means that the development app has now accepted the Captcha challenge.
You should now get an SMS to the phone number you entered earlier with the verification code. Enter the code and click "Register" and you will now be registered as a standalone device as desired.

### webpack

Some parts of the app (such as the Sticker Creator) have moved to webpack.
Expand Down