Fix folder sync for contacts without a public phone number#7741
Open
huzvanec wants to merge 1 commit intosignalapp:mainfrom
Open
Fix folder sync for contacts without a public phone number#7741huzvanec wants to merge 1 commit intosignalapp:mainfrom
huzvanec wants to merge 1 commit intosignalapp:mainfrom
Conversation
Contacts without a public phone number did not sync to desktop because Recipient.contact.serviceId was missing. Contacts are now primarily identified using serviceIdBinary.
jamiebuilds-signal
approved these changes
Mar 2, 2026
Member
|
Cherry picking this into our next release, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist:
Contributor checklist:
mainbranchpnpm run readyrun passes successfully (more about tests here)Description
When adding a user without a public phone number to a folder on mobile, the contact did not sync to desktop. The
recipientToConversationIdfunction relied onRecipient.contact.serviceId, which is often (always during my testing) undefined.This led to all contacts falling back to being identified by their phone numbers (e164) and contacts without a public phone number caused an error and didn't get added to the folder.
This PR fixes this by identifying contacts primarily by their
serviceIdBinarywhich is always present.Tested on Android 16 -> Debian GNU/Linux 13 (trixie) x86_64 (against prod servers).
Example error raised for contacts without public phone numbers: