Fix attachment names from using the wrong year#5942
Closed
MarlowBrown wants to merge 1 commit intosignalapp:mainfrom
Closed
Fix attachment names from using the wrong year#5942MarlowBrown wants to merge 1 commit intosignalapp:mainfrom
MarlowBrown wants to merge 1 commit intosignalapp:mainfrom
Conversation
…he calendar year). According to apples documentation both of them for the most part deliver the same result, however there are certain occasions that it can produce different ones. (cherry picked from commit bffba0bc97fa3cde53b4fb0dece2d50f4cd5e8af)
3 tasks
Contributor
|
Thanks for the contribution! I can get this merged internally, pending the name/email info I requested on other PRs. |
Contributor
|
This was merged internally as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
This bug
fixes #5932. This bug originated from using YYYY (Week of Year) instead of yyyy (The calendar year). According to Apple's documentation, both of them for the most part deliver the same result; however, there are certain occasions when it can produce different ones.To test that my fix has worked I changed my system time to the reported time used in the bug report. I then performed the step for the bug and the bug did not happen anymore.