Fixed Navigation Bar disappearing on zooming in and out.#5944
Closed
MarlowBrown wants to merge 1 commit intosignalapp:mainfrom
Closed
Fixed Navigation Bar disappearing on zooming in and out.#5944MarlowBrown wants to merge 1 commit intosignalapp:mainfrom
MarlowBrown wants to merge 1 commit intosignalapp:mainfrom
Conversation
…eappear while specifically zooming on the MediaPageViewController. (cherry picked from commit ca57ff35dde20e8199e1d7512c9d800356c601cd)
3 tasks
Contributor
sashaweiss-signal
left a comment
sashaweiss-signal
left a comment
There was a problem hiding this comment.
Thanks for this contribution! I'll plan to remove the comment when I make the internal commit, and fix up the whitespace changes that are failing our linter scripts.
| delegate?.mediaItemViewControllerWillBeginZooming(self) | ||
| } | ||
|
|
||
| //This is called at the end of whenever we zoom in, or zoom out. "Zooming" in this context means both zooming in and out. |
Contributor
There was a problem hiding this comment.
Nit: this comment isn't adding much.
Author
|
That sounds good! Thank you very much! |
Contributor
|
This was merged internally as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
Fixed a bug causing the navigation bar to disappear and not able to reappear while specifically zooming on the MediaPageViewController. I tested this by repeatedly trying different combinations of tapping and zooming in and out of an image to make the navigation bar appear and disappear. This
fixes #5889.Simulator.Screen.Recording.-.iPhone.16.-.2025-01-22.at.15.08.06.mp4