#5921 photo picker for stories cannot pick new photos#5946
Closed
MarlowBrown wants to merge 5 commits intosignalapp:mainfrom
Closed
#5921 photo picker for stories cannot pick new photos#5946MarlowBrown wants to merge 5 commits intosignalapp:mainfrom
MarlowBrown wants to merge 5 commits intosignalapp:mainfrom
Conversation
added 4 commits
January 23, 2025 19:02
…doesnt do anything. (cherry picked from commit d75390dcffb95b3070378c6b67b0701529a2aa91)
…icker and sending the user to the apps privacy settings. The privacy button is currently only long pressable, so I need to make it the primary action that happens when its tapped. (cherry picked from commit c6caddcf3fb9706d9672c3aa50ecb3af67bdeb50)
…ingle taps. (cherry picked from commit b1a9a8d99bbed5991146d4f1df316f049504373d)
…r the photo authorization status is set to limited or not. (cherry picked from commit 47cb8ae90487ee9725419b22999a5b005346984e)
3 tasks
Contributor
|
Hey @MarlowBrown! Would you mind providing screenshots of the change you made? We've spent some time looking into using the system photo picker, but this might be an acceptable workaround for the time being. |
Author
|
I actually have a video of the entire flow. Here it is. Simulator.Screen.Recording.-.iPhone.16.-.2025-01-23.at.18.44.40.mp4 |
Contributor
|
Hey @MarlowBrown, thanks for the contribution. It turns out we actually have designs to address this in a different way, because we know this is a common pain point. I'm gonna close out this PR as a result. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
Pull Request Description
This pull request proposes a solution to the issue where the photo picker for stories in Signal cannot pick new photos. The current custom photo picker only enumerates photos for which Signal has been granted access, limiting users to selecting only previously granted photos.
Solution Overview
The proposed solution is to use the native iOS image picker, allowing users to easily select and pick any photo on their device. This change aims to improve the user experience by providing a more streamlined and intuitive way to select photos for stories, while maintaining user control over their privacy settings.
Specifically, this pull request addresses the issue of Signal's custom photo picker not being able to pick new photos, as reported in #5921.
Testing and Verification
To ensure the effectiveness of this solution, I conducted thorough testing on both iPhone and iPad devices. I varied the photo access permissions to simulate different user scenarios, verifying that the intended behavior was achieved. Specifically, I confirmed that when photo access permissions are limited, users can interact with the button to select more photos from the limited photo picker.