Skip to content

Allow the user to open truncated messages in EditHistoryViewController#5952

Closed
MarlowBrown wants to merge 1 commit intosignalapp:mainfrom
MarlowBrown:#5774-CantExpandLongMessagesInEditHistory
Closed

Allow the user to open truncated messages in EditHistoryViewController#5952
MarlowBrown wants to merge 1 commit intosignalapp:mainfrom
MarlowBrown:#5774-CantExpandLongMessagesInEditHistory

Conversation

@MarlowBrown
Copy link

First time contributor checklist

Contributor checklist

  • My commits are rebased on the latest main branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
  • iPhone 16 iOS 18.2

Description

This small change fixes #5774 by allowing the user to open older messages and the beginning message when they have truncated content in them. I tested this by having several edited messages with truncated content and being able to open each one.

(cherry picked from commit 084e312338f0978a1c9420105a89ddd79c83ef54)
@sashaweiss-signal
Copy link
Contributor

This change seems reasonable to me! I can get this merged internally.

@sashaweiss-signal
Copy link
Contributor

To do so, I'll just need the info requested on #5943 (comment).

@MarlowBrown
Copy link
Author

Sounds good! I've already sent you an email! 👍

@sashaweiss-signal
Copy link
Contributor

This was merged internally as e06b9d5dfb, which should become public in a week or two with an upcoming release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants