Open
Conversation
|
This is really awesome |
Author
|
@naoki-deva Thank you! Glad you liked it. |
Contributor
|
Thanks for this! This is something we're interested in adopting, but since it has persisted-data implications (and eventually may be something we want to sync across clients), we'll need to give this a more thorough evaluation. For example, we might want to use a different mechanism for the persistence than I can't guarantee when we'll slot that in, but I'm going to leave this PR open until we do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
This PR adds manual reordering for installed sticker packs on iOS.
Installed packs were previously shown by dateCreated. This change introduces a persisted custom order that users can manage via drag and drop in Manage Stickers, and the same order is now used in Sticker Picker.
This feature has been requested by the community since 2021:
https://community.signalusers.org/t/ability-to-reorder-sticker-packs-desktop-ios/29124
and brings iOS in line with Android’s existing sticker-pack reordering behavior.
Scope note: this is a client-only iOS change with local persistence (KeyValueStore) and no protocol or backend changes.
Behavior details:
Testing
Demo
Attached demo showing drag-and-drop reorder and matching Sticker Picker order.
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-02-28.at.01.55.39.mov