Validate file paths in device transfer to prevent path traversal#6218
Open
rm335 wants to merge 1 commit intosignalapp:mainfrom
Open
Validate file paths in device transfer to prevent path traversal#6218rm335 wants to merge 1 commit intosignalapp:mainfrom
rm335 wants to merge 1 commit intosignalapp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Description
The device transfer restore flow uses
file.relativePathandfile.identifierfrom the received protobuf manifest to construct file paths. These values originate from an external device via MultipeerConnectivity and are not validated on the receiving side.The sender already validates paths in
pathRelativeToAppSharedDirectory()(checking for..,.,~), but the receiver did not apply the same validation. A crafted manifest with../inrelativePathcould cause files to be written outside the intendedappSharedDataDirectory.Fix: Adds a
sanitizedPath(for:within:)helper that resolves the path viaURL.standardizedand verifies it stays within the base directory. Applied to all three affected code paths:moveManifestFiles()(modern restore)restoreTransferredDataLegacy()(legacy restore)verifyTransferCompletedSuccessfully()(verification)Legitimate transfers are unaffected — valid relative paths like
Attachments/uuid/file.datpass the check.