fix(langchain): use default EmbeddingInvocation operation_name instead of hardcoded value#214
Open
adityamehra wants to merge 1 commit intomainfrom
Open
fix(langchain): use default EmbeddingInvocation operation_name instead of hardcoded value#214adityamehra wants to merge 1 commit intomainfrom
adityamehra wants to merge 1 commit intomainfrom
Conversation
…d of hardcoded value The langchain instrumentation was setting operation_name="embedding" (singular) which overrode the correct semantic convention default of "embeddings" (plural) defined in EmbeddingInvocation types.py. Remove the explicit override so the dataclass default from GenAiOperationNameValues.EMBEDDINGS is used. Add embedding tests for both packages: - util-genai: default operation_name, semconv attributes, span name, error path - langchain: VCR integration tests for success and error paths Co-authored-by: Cursor <cursoragent@cursor.com>
etserend
approved these changes
Feb 17, 2026
Contributor
|
Do we need to add the changes to Changelog? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operation_name="embedding"(singular) from the langchain embedding wrapper, allowing the correct semantic convention default"embeddings"(plural) fromEmbeddingInvocationtypes.py to be usedutil/opentelemetry-util-genaicovering default operation_name, semconv attributes, span name formatting, error path, and override behaviourtest_langchain_llm.pyTest plan
ruff check+ruff format)util/opentelemetry-util-genai(8 tests)instrumentation-genai/opentelemetry-instrumentation-langchain(2 tests)Made with Cursor