Skip to content

run scripts/build.sh in a Linux container #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

run scripts/build.sh in a Linux container #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5408f82
Upgrade to Go 1.23
paul-fastly Mar 17, 2025
a36dfde
Comment a function
paul-fastly Mar 17, 2025
7612c57
Use a docker image for running scripts/build.sh so it works on MacOS
paul-fastly Mar 17, 2025
b90afac
Changelog & version
paul-fastly Mar 17, 2025
660cdf9
Undo the version bumpb
paul-fastly Mar 17, 2025
9017e45
I don't need to bump the version anymore
paul-fastly Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# Golang Module Release Notes

## 1.14.1 2025-03-17
* Run `scripts/build.sh` in a Docker image (in `make build`) so that it works on MacOS.

## 1.14.0 2024-11-18

* Allow the agent to edit application response headers
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
build: ## build and lint locally
./scripts/build.sh
docker run --rm -v "$(CURDIR):/temp" -w /temp golang:1.23 ./scripts/build.sh

# clean up each time to make sure nothing is cached between runs
#
Expand Down
2 changes: 2 additions & 0 deletions responsewriter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ func (w *responseRecorder) WriteHeader(status int) {
w.base.WriteHeader(status)
}

// Merge in our header modifications using the appropriate functions in
// the Header type in net/http
func (w *responseRecorder) mergeHeader() {
hdr := w.base.Header()
for _, a := range w.actions {
Expand Down