Passive Two-way Ranging (UWTWR) MAC protocol added#20
Passive Two-way Ranging (UWTWR) MAC protocol added#20yuehanjianghh wants to merge 5 commits intosignetlabdei:masterfrom
Conversation
|
Hi @yuehanjianghh , looking at your PR, I noticed that you need it to rebase it over the master branch, Also, I noticed that the changes are missing the compilation directives for your module: basically you need to tell the main configure.ac and Makefile.am (that are found in DESERT_Framework/DESERT) about your new module, otherwise it won't be compiled on installation. Thank you |
7671ea5 to
efe4b3d
Compare
|
Hi @obolo, thank you very much for pointing them out. I have rebased and updated the configure.ac and Makefile.am files. Hope it will compile now. |
|
Hi @yuehanjianghh , I have a few questions:
|
fab08c3 to
61d6cd8
Compare
fedefava86
left a comment
There was a problem hiding this comment.
@yuehanjianghh i believe you basically ported the full master branch on your branch instead of rebasing yours against master. You needed to sync your fork's master with our master and then rebase the branch. I guess you need to fix the history now, otherwise we'll not able to merge this branch. thx
61d6cd8 to
a40fd29
Compare
@ fedefava86 thanks so much for the info. I wanted to rework on this branch but made this mistake. I think now it's fixed as suggested. |
@ciminoV thanks a lot for the great questions! I am reworking on this protocol recently and will address these comments. In case of any aspect that I may have missed, please feel free to ask.
|
confirmed, it is fixed now, thx |
Hi, this is the protocol UWTWR for passive two-way ranging.
AAUV (active) polling 2 NODEs alternately, and PAUV (passive) is receiving.
Looking forward to your feedback. Many thanks!
Best regards,
Yuehan