uwapplicon_sea_modem: Applicon SeaModem Integration#54
Open
applicon-develop wants to merge 2 commits intosignetlabdei:masterfrom
Open
uwapplicon_sea_modem: Applicon SeaModem Integration#54applicon-develop wants to merge 2 commits intosignetlabdei:masterfrom
applicon-develop wants to merge 2 commits intosignetlabdei:masterfrom
Conversation
Implementation of the driver to use Applicon SeaModem within the DESERT Framework. An example TDMA tcl script is available for testing.
MetalKnight
requested changes
Dec 4, 2025
dcostan
reviewed
Dec 4, 2025
refactor: `UwAppliconInterpr`updated by removing `w_term` and simplify its destructor, and add `override` specifiers to `UwAppliconSeaModem'
ciminoV
requested changes
Dec 10, 2025
| @@ -0,0 +1,156 @@ | |||
| # | |||
| # Copyright (c) 2014 Regents of the SIGNET lab, University of Padova. | |||
| @@ -0,0 +1,30 @@ | |||
| # | |||
| # Copyright (c) 2012 Regents of the SIGNET lab, University of Padova. | |||
| @@ -0,0 +1,189 @@ | |||
| # | |||
| # Copyright (c) 2014 Regents of the SIGNET lab, University of Padova. | |||
| @@ -0,0 +1,168 @@ | |||
| # | |||
| # Copyright (c) 2014 Regents of the SIGNET lab, University of Padova. | |||
| @@ -0,0 +1,33 @@ | |||
| #!/bin/sh | |||
| # | |||
| # Copyright (c) 2013 Regents of the SIGNET lab, University of Padova. | |||
| //std::cout << "DEBUG: crc_check found TRUE (or assumed true)" << std::endl; | ||
| } | ||
| } else { | ||
| std::cout << "DEBUG: crc_check field NOT FOUND" << std::endl; |
Contributor
There was a problem hiding this comment.
Do you need this else or is just for debug purposes?
| enum class Response { | ||
| RECV, | ||
| MSGS, | ||
| AOK, // <-- NUOVA RIGA |
| UwAppliconSeaModem::start() | ||
| { | ||
| if (modem_address == "") { | ||
| std::cout << "ERROR: Modem address not set!" << std::endl; |
Contributor
There was a problem hiding this comment.
remove this cout since you print the same message on log
| } | ||
|
|
||
| if (!p_connector->openConnection(modem_address)) { | ||
| std::cout << "ERROR: connection to modem failed to open: " |
| UwAppliconSeaModem::stop() | ||
| { | ||
|
|
||
| std::cout << "UwAppliconSeaModem::stop() close conn " << std::endl; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the driver to use Applicon SeaModem within the DESERT Framework. An example TDMA tcl script is available for testing.