Implement builder ssz flow #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
commented
Jan 24, 2025
pawanjay176
reviewed
Feb 11, 2025
common/src/lib.rs
Outdated
| metadata: EmptyMetadata {}, | ||
| data: body, | ||
| }; | ||
| tokio::task::spawn_blocking(move || { |
Member
There was a problem hiding this comment.
Why are we spawning a new task to just convert to bytes?!
Member
Author
There was a problem hiding this comment.
I'm not sure why were spawning a new task, we were doing it in the JSON case in the existing build_response function so I just kept it the same here.
Member
There was a problem hiding this comment.
Removed this, i'm not sure why we had this in the first place.
pawanjay176
force-pushed
the
builder-ssz-flow
branch
3 times, most recently
from
c7aee9c to
955a7d9
Compare
pawanjay176
force-pushed
the
builder-ssz-flow
branch
7 times, most recently
from
4f0b63d to
a0eb6e8
Compare
pawanjay176
force-pushed
the
builder-ssz-flow
branch
from
a0eb6e8 to
ea8ee59
Compare
pawanjay176
force-pushed
the
builder-ssz-flow
branch
2 times, most recently
from
fb9f35e to
4d3bbaa
Compare
pawanjay176
force-pushed
the
builder-ssz-flow
branch
from
4d3bbaa to
8b2dcdc
Compare
Member
|
Added support for ssz with register_validators as well and added tests. @eserilev can't seem to add you for review. PTAL. |
Member
AI slop |
realbigsean
reviewed
Mar 7, 2025
realbigsean
reviewed
Mar 7, 2025
This was referenced Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spec: ethereum/builder-specs#104
ForkVersionDecodein LH. It was required so I could create the relevant axum extractor.JsonOrSszWithForkextractor which can extract request body data that implsDeserializeOwned+ForkVersionDecode.build_response_with_headersForkVersionedResponse& serializes to JSON