set process_cpu_seconds_total to type counter #7802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @carekb684 thanks for contributing! The approach looks solid. Can you run it locally, capture metrics with prometheus and grafana and show in a screen shot that the metric renders nicely? |
carekb684
force-pushed
the
3108-set_process_cpu_seconds_total_to_type_counter
branch
from
638e777 to
f82cbe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Closes #3108
Proposed Changes
Changed the Prometheus metric process_cpu_seconds_total from a Gauge to a Counter, which is more appropriate for representing cumulative CPU time.
Additional Info
I found this issue and wanted to contribute.
I chose the approach of resetting the counter and then incrementing it with the new value for simplicity.
An alternative I considered was storing an extra state (previous_seconds) and incrementing only the calculated diff. However, I decided against this to avoid added complexity and state management, since the reset + increment pattern works well in this case.