Remove unused deps more aggressively #7851
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
I was playing around with
cargo machete
and noticed that it more aggressively detects unused deps thancargo udeps
.After running
cargo machete --with-metadata
and going through the list, despite a few false positives, there were quite a few (seemingly) unused dependencies.Additional Info
Maybe we could consider switching to
cargo machete
overcargo udeps
(or potentially run both) although I'd be concerned with the number of false positives. More conservative settings find significantly less and so is less compelling