Skip to content

Conversation

macladson
Copy link
Member

Proposed Changes

I was playing around with cargo machete and noticed that it more aggressively detects unused deps than cargo udeps.
After running cargo machete --with-metadata and going through the list, despite a few false positives, there were quite a few (seemingly) unused dependencies.

Additional Info

Maybe we could consider switching to cargo machete over cargo udeps (or potentially run both) although I'd be concerned with the number of false positives. More conservative settings find significantly less and so is less compelling

@macladson macladson added code-quality work-in-progress PR is a work-in-progress labels Aug 11, 2025
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed work-in-progress PR is a work-in-progress labels Aug 13, 2025
@macladson macladson added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 19, 2025
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of Qs about things that look odd to me.

@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Aug 20, 2025
@mergify mergify bot added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 20, 2025
@michaelsproul michaelsproul added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality waiting-on-author The reviewer has suggested changes and awaits thier implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants