Skip to content

Upgrade rust-eth-kzg to 0.8.0 #7870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 18, 2025
Merged

Upgrade rust-eth-kzg to 0.8.0 #7870

merged 6 commits into from
Aug 18, 2025

Conversation

jimmygchen
Copy link
Member

@jimmygchen jimmygchen commented Aug 13, 2025 •
edited
Loading

Issue Addressed

#7864

The main breaking change in v0.8.0 is the TrustedSetup initialisation - it now requires a json string via PeerDASTrustedSetup::from_json.

@jimmygchen jimmygchen added ready-for-review The code is ready for review v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky labels Aug 13, 2025
@mergify Mergify
Copy link

mergify bot commented Aug 13, 2025

This pull request has merge conflicts. Could you please resolve them @jimmygchen? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Aug 13, 2025
@jimmygchen
Merge remote-tracking branch 'origin/unstable' into kzg-upgrade
385644a 
# Conflicts:
#	beacon_node/beacon_chain/src/kzg_utils.rs
#	beacon_node/execution_layer/src/test_utils/execution_block_generator.rs
#	beacon_node/src/config.rs
@jimmygchen
Fix lint
ee9af3d
@jimmygchen jimmygchen added ready-for-review The code is ready for review das Data Availability Sampling and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Aug 13, 2025
eserilev
eserilev approved these changes Aug 15, 2025
View reviewed changes
Copy link
Member

@eserilev eserilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kevaundray
kevaundray approved these changes Aug 17, 2025
View reviewed changes
Copy link
Contributor

@kevaundray kevaundray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- note that if you wanted to, you could call TrustedSetup::default: https://github.com/crate-crypto/rust-eth-kzg/blob/d49e9057ebce035e6a6024f32ae920fb20819ff8/crates/trusted_setup/src/lib.rs#L82

@jimmygchen
Copy link
Member Author

LGTM -- note that if you wanted to, you could call TrustedSetup::default: https://github.com/crate-crypto/rust-eth-kzg/blob/d49e9057ebce035e6a6024f32ae920fb20819ff8/crates/trusted_setup/src/lib.rs#L82

Thanks @kevaundray !

I had a look into the code and currently this may be a bit of work until we remove / feature gate c-kzg and remove the --trusted-setup-override flag, as we currently pass the bytes array through from the config object, which is also used by c-kzg.

I think we can probably do this when we get to #6107, and it's likely going to simplify a lot of things (remove trusted setup bytes from client config etc)

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 18, 2025
mergify bot added a commit that referenced this pull request Aug 18, 2025
@mergify
Merge of #7870
5c9113d
@mergify mergify bot mentioned this pull request Aug 18, 2025
Closed
6 tasks
@mergify mergify bot merged commit aa8cba3 into sigp:unstable Aug 18, 2025
34 checks passed
@jimmygchen jimmygchen mentioned this pull request Aug 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eserilev eserilev eserilev approved these changes

+1 more reviewer

@kevaundray kevaundray kevaundray approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
das Data Availability Sampling ready-for-merge This PR is ready to merge. v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmygchen @eserilev @kevaundray