Skip to content

Bump ssz_types to v0.12.2 #8032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: unstable
Choose a base branch
from
Open

Bump ssz_types to v0.12.2 #8032

wants to merge 12 commits into from

Conversation

macladson
Copy link
Member

@macladson macladson commented Sep 11, 2025 •
edited
Loading

Issue Addressed

#8012

Proposed Changes

Replace all instances of VariableList::from and FixedVector::from to their try_from variants.

While I tried to use proper error handling in most cases, there were certain situations where adding an expect for situations where try_from can trivially never fail avoided adding a lot of extra complexity.

@macladson macladson requested a review from jxs as a code owner September 11, 2025 16:18
@macladson macladson added the work-in-progress PR is a work-in-progress label Sep 11, 2025
michaelsproul
michaelsproul requested changes Sep 15, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Just a few expects here and there that I wonder if we should remove

@macladson macladson added ready-for-review The code is ready for review dependencies Pull requests that update a dependency file waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed work-in-progress PR is a work-in-progress ready-for-review The code is ready for review labels Sep 15, 2025
@macladson macladson added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 15, 2025
@michaelsproul michaelsproul added v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky v8.0.0 Q4 2025 Fusaka Mainnet Release waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky ready-for-review The code is ready for review labels Sep 16, 2025
@michaelsproul
Copy link
Member

Sorry @macladson, after discussing with Jimmy we decided it would be better to remove these expects before merging. Can you have another go at propagating the errors, especially the ones for the JSON types, and anything that is reachable at runtime (anything outside a static/const).

macladson
macladson commented Sep 20, 2025
View reviewed changes
macladson
macladson commented Sep 20, 2025
View reviewed changes
@macladson macladson added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 22, 2025
@mergify Mergify
Copy link

mergify bot commented Sep 22, 2025

Some required checks have failed. Could you please take a look @macladson? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 22, 2025
@macladson macladson added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 22, 2025
@macladson macladson mentioned this pull request Sep 24, 2025
Merged
@jimmygchen jimmygchen removed the v8.0.0 Q4 2025 Fusaka Mainnet Release label Sep 30, 2025
@macladson macladson added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 30, 2025
@macladson macladson changed the title Bump ssz_types to v0.12.1 Bump ssz_types to v0.12.2 Sep 30, 2025
@macladson macladson added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 30, 2025
@mergify Mergify
Copy link

mergify bot commented Sep 30, 2025

Some required checks have failed. Could you please take a look @macladson? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 30, 2025
@macladson macladson added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Sep 30, 2025
@macladson macladson mentioned this pull request Oct 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsproul michaelsproul michaelsproul requested changes

@jxs jxs Awaiting requested review from jxs jxs is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file ready-for-review The code is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@macladson @michaelsproul @jimmygchen