Skip to content

Conversation

macladson
Copy link
Member

Issue Addressed

#6022

Proposed Changes

Use alloy_rpc_types::Transaction to replace the ethers_core::Transaction inside the execution block generator.

Additional Info

This along with #8139 and #8140 should remove ethers from the codebase entirely.
I also bump all alloy crate versions to ensure compatibility.

@macladson macladson added the ready-for-review The code is ready for review label Oct 1, 2025
Comment on lines +102 to +105
alloy-consensus = { version = "=1.0.37", default-features = false }
alloy-primitives = { version = "=1.4.0", features = ["rlp", "getrandom"] }
alloy-rlp = "=0.3.12"
alloy-rpc-types = "=1.0.37"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was running into issues with compatibility so I've bumped (and pinned) the alloy crates to the same/compatible versions. When we go to update them, we can update them all at the same time to ensure we don't break compatibility. An alternative is to just import alloy and enable the features we need, but I suspect we'll end up with unnecessary bloat if we go down that path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review The code is ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant