Automatically pass spans into blocking handles #8158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
added
work-in-progress
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
bot
added
waiting-on-author
eserilev
force-pushed
the
pass-spans-into-blocking-handles
branch
from
96975a7 to
1943507
Compare
eserilev
commented
Oct 7, 2025
|
|
||
| /// Fork choice root spans | ||
| pub const SPAN_RECOMPUTE_HEAD: &str = "recompute_head_at_slot"; | ||
| pub const SPAN_RECOMPUTE_HEAD: &str = "recompute_head_at_slot_internal"; |
There was a problem hiding this comment.
I think I can delete this
eserilev
commented
Oct 7, 2025
|
|
||
| // Filter uninteresting blocks from the chain segment in a blocking task. | ||
| let chain = self.clone(); | ||
| let filter_chain_segment = debug_span!("filter_chain_segment"); |
There was a problem hiding this comment.
not sure if there's a parent span here, might need to keep the debug_span!
eserilev
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have to manually pass spans across threads (i.e. during
spawn_blocking_handleinvocations). This PR ensures that the current span is always passed across threads for:spawn_blocking_handlespawn_blocking_with_rayon_asyncspawn_blocking_with_rayonIf there is no current span, nothing will happen