Skip to content

Fix duplicate fields being logged when the field exists in both the span and the event #8183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

Fix duplicate fields being logged when the field exists in both the span and the event #8183

merged 2 commits into from
Oct 13, 2025
+63 −51

Conversation

jimmygchen
Copy link
Member

Issue Addressed

Closes #7995.

Fix duplicate fields being logged when the field exists in both the span and the event. Prefer event fields when this happens.

Sep 15 08:13:46.339 WARN State cache missed state_root: 0xc34826ff7794de63a553832b7aff13572d1c716b9e03d5ef7b29649adf98abe2, block_root: 0xf16d3f5b4cc6ec876b7faeccd9f2d4102dc56ed32e828754b62601637910ec1f, state_root: 0xc34826ff7794de63a553832b7aff13572d1c716b9e03d5ef7b29649adf98abe2, block_root: 0xf16d3f5b4cc6ec876b7faeccd9f2d4102dc56ed32e828754b62601637910ec1f

becomes

Sep 15 08:13:46.339 WARN State cache missed state_root: 0xc34826ff7794de63a553832b7aff13572d1c716b9e03d5ef7b29649adf98abe2, block_root: 0xf16d3f5b4cc6ec876b7faeccd9f2d4102dc56ed32e828754b62601637910ec1f

@jimmygchen jimmygchen added ready-for-review The code is ready for review UX-and-logs v8.0.0 Q4 2025 Fusaka Mainnet Release labels Oct 9, 2025
@jimmygchen
Fix duplicate fields being logged when the field exists in both the s…
cb59682 
…pan and the event. Prefer event fields when this happens.
@mergify Mergify
Copy link

mergify bot commented Oct 9, 2025

Some required checks have failed. Could you please take a look @jimmygchen? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 9, 2025
@jimmygchen jimmygchen added ready-for-review The code is ready for review and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 10, 2025
@jimmygchen jimmygchen mentioned this pull request Oct 10, 2025
Open
2 tasks
jimmygchen added a commit to jimmygchen/lighthouse that referenced this pull request Oct 10, 2025
@jimmygchen
Squashed commit of the following (sigp#8183):
e69675b 
commit bf10815
Author: Jimmy Chen <[email protected]>
Date:   Fri Oct 10 11:30:45 2025 +1100

    Fix tests and add some tests.

commit cb59682
Author: Jimmy Chen <[email protected]>
Date:   Fri Oct 10 00:41:17 2025 +1100

    Fix duplicate fields being logged when the field exists in both the span and the event. Prefer event fields when this happens.
michaelsproul
michaelsproul approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM. And test looks good

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Oct 13, 2025
@mergify mergify bot added the queued label Oct 13, 2025
mergify bot added a commit that referenced this pull request Oct 13, 2025
@mergify
Merge of #8183
d50caae
@mergify mergify bot mentioned this pull request Oct 13, 2025
Closed
6 tasks
jimmygchen added a commit to jimmygchen/lighthouse that referenced this pull request Oct 13, 2025
@jimmygchen
Squashed commit of the following (sigp#8183):
dfe7844 
commit bf10815
Author: Jimmy Chen <[email protected]>
Date:   Fri Oct 10 11:30:45 2025 +1100

    Fix tests and add some tests.

commit cb59682
Author: Jimmy Chen <[email protected]>
Date:   Fri Oct 10 00:41:17 2025 +1100

    Fix duplicate fields being logged when the field exists in both the span and the event. Prefer event fields when this happens.
@mergify mergify bot merged commit 178df7a into sigp:unstable Oct 13, 2025
37 checks passed
@mergify mergify bot removed the queued label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelsproul michaelsproul michaelsproul approved these changes

@macladson macladson Awaiting requested review from macladson

@pawanjay176 pawanjay176 Awaiting requested review from pawanjay176

Assignees

No one assigned

Labels

ready-for-merge This PR is ready to merge. UX-and-logs v8.0.0 Q4 2025 Fusaka Mainnet Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimmygchen @michaelsproul