Delete attester cache #8469
Open
Delete attester cache #8469
+106
−492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmygchen
force-pushed
the
delete-attester-cache
branch
2 times, most recently
from
b95a664 to
224fbff
Compare
Co-authored-by: Michael Sproul <[email protected]>
jimmygchen
force-pushed
the
delete-attester-cache
branch
from
224fbff to
ad4cf8f
Compare
dapplion
reviewed
Nov 26, 2025
| %request_slot, | ||
| "Attester cache miss" | ||
| ); | ||
| let (advanced_state_root, mut state) = self |
Collaborator
There was a problem hiding this comment.
Can you add metrics for the number of times we hit this code path? Would be nice to have a histogram here or instrumentation of the time spent computing the hot state
Member
Author
There was a problem hiding this comment.
Good idea - I've instrumented the produce_unaggregated_attestation code path, and we already have a span for get_advanced_hot_state, so this should give us good visibility.
Collaborator
|
Nice simplification! |
michaelsproul
added
code-quality
waiting-on-author
jimmygchen
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Fixes attester cache write lock contention. Alternative to #8463.
Description
Deletes the attester cache which was causing lock contention across multiple hot code paths:
We now use the state cache directly via
get_advanced_hot_state, which builds all caches without lock contention.