fix(peerdb): use start_slot instead of end_slot for safer actions #8498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Which issue # does this PR address?
None
Proposed Changes
Discussed in private with @jimmygchen, Lighthouse's
earliest_available_slotis guaranteed to always align with epoch boundaries, but as a safety implementation, we should usestart_slotjust in case other clients differ in their implementations.At least we agreed it would be safer for
synced_peers_for_epoch, I also made the change inhas_good_custody_range_sync_peer, but this is to be reviewed please.Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.