Skip to content

Conversation

@0xMushow
Copy link

Issue Addressed

Which issue # does this PR address?
None

Proposed Changes

All of these are performing a check, and adding a batch, or creating a new lookup, or a new query, etc..
Hence all of these limits would be off by one.

Example:

// BACKFILL_BATCH_BUFFER_SIZE = 5
  if self.batches.iter().filter(...).count() >= BACKFILL_BATCH_BUFFER_SIZE {
      return None;  // ← REJECT
  }
  // ... later adds batch via Entry::Vacant(entry).insert(...)

Without the > being changed to a >= , we would allow 6. The same idea applies to all changes proposed.

Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.

@0xMushow 0xMushow changed the title Fix/sync off by one boundaries Enforce stricter checks on certain constants Nov 28, 2025
@cla-assistant
Copy link

cla-assistant bot commented Nov 28, 2025

CLA assistant check
All committers have signed the CLA.

@0xMushow 0xMushow changed the base branch from stable to unstable November 28, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants