Skip to content

fix: populate participating_peers to enable correct peer penalization #8526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sashass1315 wants to merge 1 commit into
base: stable
Choose a base branch
from
Open

fix: populate participating_peers to enable correct peer penalization #8526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions beacon_node/network/src/sync/backfill_sync/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ impl<T: BeaconChainTypes> BackFillSync<T> {
for (column, peer) in faulty_peers {
failed_columns.insert(*column);
failed_peers.insert(*peer);
self.participating_peers.insert(*peer);
}

// Only retry if peer failure **and** retries haven't been exceeded
Expand Down Expand Up @@ -361,6 +362,8 @@ impl<T: BeaconChainTypes> BackFillSync<T> {
if !batch.is_expecting_request_id(&request_id) {
return Ok(());
}
// Record the peer that participated in serving this batch (even if errored)
self.participating_peers.insert(*peer_id);
debug!(batch_epoch = %batch_id, error = ?err, "Batch download failed");
match batch.download_failed(Some(*peer_id)) {
Err(e) => self.fail_sync(BackFillError::BatchInvalidState(batch_id, e.0)),
Expand Down Expand Up @@ -409,6 +412,7 @@ impl<T: BeaconChainTypes> BackFillSync<T> {

match batch.download_completed(blocks, *peer_id) {
Ok(_) => {
self.participating_peers.insert(*peer_id);
let awaiting_batches =
self.processing_target.saturating_sub(batch_id) / BACKFILL_EPOCHS_PER_BATCH;
debug!(
Expand Down