Skip to content

Conversation

@macladson
Copy link
Member

Proposed Changes

There are certain crates which we re-export within types which creates a fragmented DevEx, where there are various ways to import the same crates.

// consensus/types/src/lib.rs
pub use bls::{
    AggregatePublicKey, AggregateSignature, Error as BlsError, Keypair, PUBLIC_KEY_BYTES_LEN,
    PublicKey, PublicKeyBytes, SIGNATURE_BYTES_LEN, SecretKey, Signature, SignatureBytes,
    get_withdrawal_credentials,
};
pub use context_deserialize::{ContextDeserialize, context_deserialize};
pub use fixed_bytes::FixedBytesExtended;
pub use milhouse::{self, List, Vector};
pub use ssz_types::{BitList, BitVector, FixedVector, VariableList, typenum, typenum::Unsigned};
pub use superstruct::superstruct;

This PR removes these re-exports and makes it explicit that these types are imported from a non-consensus/types crate.

Additional Information

This PR shouldn't lead to any actual changes in crates' dependencies or compilation, although they will now be explicitly listed in Cargo.lock.

@macladson macladson added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Dec 7, 2025
@mergify
Copy link

mergify bot commented Dec 8, 2025

This pull request has merge conflicts. Could you please resolve them @macladson? 🙏

@mergify mergify bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Dec 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality waiting-on-author The reviewer has suggested changes and awaits thier implementation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant