Scrap redundant docker builds on releases#8999
Open
antondlr wants to merge 5 commits intorelease-v8.1from
Open
Scrap redundant docker builds on releases#8999antondlr wants to merge 5 commits intorelease-v8.1from
antondlr wants to merge 5 commits intorelease-v8.1from
Conversation
Member
|
We might need to target this at |
Member
Author
|
it will run the workflow from the tagged branch. |
add `:latest` tag only if version matches regex
antondlr
force-pushed
the
optimise-release-workflow
branch
from
f6e8c30 to
72480ae
Compare
antondlr
changed the title
Member
|
Cargo audit fail will be fixed by: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Our release workflow is pretty inefficient and slow. This PR aims to consolidate and cut down on duplicate tasks.
Proposed Changes
stablebranch and pushing a version tag.A quick win is to not fire off separate builds.
~~2) The Docker release workflow could re-use the binaries being built instead of doing its own cross-compilation. ~~
we won't take this on right now