Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
We have a legacy
TestRandomtrait which generates random types for testing and fuzzing.This function overlaps with
arbitrarywhich is used very commonly in the ecosystem.Proposed Changes
Remove
TestRandomand generate random type instances usingArbitrary.Additional Info
We have two git patches on
ethereum_sszandssz_typesto update some upstreamarbitraryinstances to be more correct. Once these have been each added into a release we can remove these patches.There are a few situations where we include a self-referential dev-dependency like this:
This forces the
arbitraryfeature when we run any tests which prevents us from skipping arbitrary tests, however we may want to remove this and make it more targeted, so certain tests run with it or without it.