[#71] Fix rounding issues in format_time_minutes#72
Open
Giles314 wants to merge 2 commits intosigrokproject:masterfrom
Open
[#71] Fix rounding issues in format_time_minutes#72Giles314 wants to merge 2 commits intosigrokproject:masterfrom
Giles314 wants to merge 2 commits intosigrokproject:masterfrom
Conversation
|
Just confirming that I'm also seeing the test failures which are fixed by this change. Before: But with the changes in this PR applied: I'm assuming these tests worked when they were written, so extra detail on my setup: I'm compiling from source on Debian trixie using the sigrok-cross-linux script in sigrok-util, with all dependencies pulled in via I've also included a short animation here showing that I've tested the change in the actual application. The commit ID is visible in the about screen, and I'm dragging a time range showing that the numbers are still formatting as the user would expect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The fix is double: