Adds dumps for SENT (SAE J2716) #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like you have a decent set of captures, I think it would be worth it to add corresponding regression tests (sigrok-test repo) |
fenugrec
approved these changes
Sep 28, 2023
Contributor
fenugrec
left a comment
fenugrec
left a comment
There was a problem hiding this comment.
- signal labels . Ok, only one signal named 'D0'; don't know if another name would make more sense. In the PD you named it 'Data'. It's probably OK as it is
- readme
- test suite PR linked : sigrokproject/sigrok-test#20
- general structure : I wonder if the folder name should include the sae-j2716 designation as well. I will leave that to project maintainer/committer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.