Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4618 +/- ##
==========================================
- Coverage 40.10% 35.96% -4.14%
==========================================
Files 155 220 +65
Lines 10044 12764 +2720
==========================================
+ Hits 4028 4591 +563
- Misses 5530 7473 +1943
- Partials 486 700 +214 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a7d1bac to
695ced1
Compare
b1ac7be to
ded7bcb
Compare
dadcd9e to
ce8540f
Compare
0a46567 to
5b16501
Compare
5ca899a to
8d3c73b
Compare
steiza
left a comment
There was a problem hiding this comment.
Awesome work! The only thing I'm not quite sure how about is how we should handle RekorVersion as a user input argument.
| KeyRef string | ||
| FulcioURL string | ||
| RekorURL string | ||
| RekorVersion uint32 |
There was a problem hiding this comment.
I'm a little nervous about adding this option - what should we do if people specify this and SigningConfig?
We could either make those options mutually exclusive (which is a pain) or always default to Rekor v1 when you aren't using SigningConfig and keep moving folks over to use SigningConfig sooner than later. I'm curious what @Hayden-IO thinks here as well.
There was a problem hiding this comment.
This is a good question, and I'm also interested in what @Hayden-IO thinks here.
There was a problem hiding this comment.
Yep, I agree with Zach. What was the need for this? The reason we went with creating a configuration for signing was to avoid manually specifying API version, as that’s not a great UX.
e3a9659 to
232a719
Compare
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
6a574b5 to
82e2d5e
Compare
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
82e2d5e to
bd2aaaf
Compare
bd2aaaf to
97edca8
Compare
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
97edca8 to
9e0cb28
Compare
Closes #4570
Summary
This change refactors the signing path in all signing and attestation commands such that all signing events occur via sigstore-go, not just those in which a signing config is used.
In cases where a signing config is not used, all prior functionality remains. This requires the construction of a signing config using TUF- or flag-provided URLs and a Rekor version flag. When a legacy bundle is requested, a legacy bundle is constructed from the new-format bundle provided by sigstore-go.