Use HTTP server for conformance testing#1038
Merged
aaronlew02 merged 1 commit intomainfrom Aug 5, 2025
Merged
Conversation
aaronlew02
force-pushed
the
conformance-server
branch
27 times, most recently
from
cf1d620 to
091b3b4
Compare
Member
|
Not sure if this is handled, but I think we need the original cli build to continue to work -- https://github.com/sigstore/root-signing-staging/blob/0b8f5f813dc2b657a8bf82b587dd2f0dd9135a20/.github/workflows/custom-test.yml#L174 uses it to keep some things in check. |
aaronlew02
force-pushed
the
conformance-server
branch
from
091b3b4 to
ad6b669
Compare
Collaborator
Author
|
@loosebazooka Great point. To prevent |
aaronlew02
force-pushed
the
conformance-server
branch
10 times, most recently
from
9535c91 to
ad6b669
Compare
Member
|
Sorry it took so long, this looks fine, the regular cli build seems to continue to work. |
loosebazooka
reviewed
Aug 5, 2025
aaronlew02
force-pushed
the
conformance-server
branch
3 times, most recently
from
1765a9e to
d4bbc12
Compare
loosebazooka
previously approved these changes
Aug 5, 2025
Member
loosebazooka
left a comment
loosebazooka
left a comment
There was a problem hiding this comment.
lgtm, just some minor things
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
aaronlew02
force-pushed
the
conformance-server
branch
from
d4bbc12 to
8bb6fc8
Compare
loosebazooka
approved these changes
Aug 5, 2025
aaronlew02
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change speeds up conformance testing by using an HTTP server.