Merged
Conversation
aaronlew02
force-pushed
the
rekor-v2
branch
3 times, most recently
from
5bb4058 to
f50c7e9
Compare
Hayden-IO
reviewed
Jun 13, 2025
sigstore-java/src/main/java/dev/sigstore/encryption/signers/Ed25519Verifier.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/rekor/v2/client/RekorV2Client.java
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/rekor/v2/client/RekorV2Client.java
Outdated
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/rekor/v2/client/RekorV2Verifier.java
Show resolved
Hide resolved
aaronlew02
force-pushed
the
rekor-v2
branch
7 times, most recently
from
f6df56d to
c270abc
Compare
aaronlew02
changed the title
aaronlew02
force-pushed
the
rekor-v2
branch
4 times, most recently
from
ff29c7d to
10e79cf
Compare
Member
loosebazooka
left a comment
loosebazooka
left a comment
There was a problem hiding this comment.
looks pretty good, just some questions I'm not sure I have the answers for.
sigstore-java/src/main/java/dev/sigstore/rekor/v2/client/RekorV2Verifier.java
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/rekor/v2/client/RekorV2Verifier.java
Show resolved
Hide resolved
sigstore-java/src/main/java/dev/sigstore/rekor/v2/client/RekorV2Verifier.java
Outdated
Show resolved
Hide resolved
Member
|
so we don't necessarily need to address those issues I brought up in this PR, but lets file issues at least. |
Signed-off-by: Aaron Lew <64337293+aaronlew02@users.noreply.github.com>
loosebazooka
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #997 and #999
Closes #1001
Summary
This change implements a client and verifier for Rekor v2.