-
Notifications
You must be signed in to change notification settings - Fork 69
chore: fix CI, bump Python version in requirements #1650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: William Woodruff <[email protected]>
.github/workflows/requirements.yml
Outdated
|
|
||
| - name: Run test install | ||
| run: python -m pip install -r install/requirements.txt | ||
| run: python -m pip install --no-deps -r install/requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: --no-deps is strictly correct in our case anyways because our requirements are fully hashed here, so all this does is work around pypa/pip#9644
Signed-off-by: William Woodruff <[email protected]>
|
NB: Once merged I'll kick off the requirements regeneration workflow to adjust for the new |
| @@ -1 +1 @@ | |||
| 3.9.16 | |||
| 3.10.19 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #1645.
jku
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I'm a bit confused now -- can the workflow be used like this? |
I thought so -- it has a |
This should unblock #1649.