Skip to content

Remove suspicion of extension bytes #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woodruffw merged 1 commit into from
Jan 15, 2026
Merged

Remove suspicion of extension bytes #1657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions sigstore/_internal/sct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,6 @@ def _pack_digitally_signed(
The format of the digitally signed data is described in IETF's RFC 6962.
"""

# No extensions are currently specified, so we treat the presence
# of any extension bytes as suspicious.
if len(sct.extension_bytes) != 0:
raise VerificationError("Unexpected trailing extension bytes")

# This constructs the "core" `signed_entry` field, which is either
# the public bytes of the cert *or* the TBSPrecertificate (with some
# filtering), depending on whether our SCT is for a precertificate.
Expand Down