Skip to content

Include SCT extension in signature data #1659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woodruffw merged 1 commit into from
Jan 16, 2026
Merged

Include SCT extension in signature data #1659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sigstore/_internal/sct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def _pack_digitally_signed(
# Assemble a format string with the certificate length baked in and then pack the digitally
# signed data
# fmt: off
pattern = f"!BBQH{len(signed_entry)}sH"
pattern = f"!BBQH{len(signed_entry)}sH{len(sct.extension_bytes)}s"
timestamp = sct.timestamp.replace(tzinfo=timezone.utc)
data = struct.pack(
pattern,
Expand All @@ -119,6 +119,7 @@ def _pack_digitally_signed(
sct.entry_type.value, # entry_type (x509_entry(0) | precert_entry(1))
signed_entry, # select(entry_type) -> signed_entry (see above)
len(sct.extension_bytes), # extensions (opaque CtExtensions<0..2^16-1>)
sct.extension_bytes,
)
# fmt: on

Expand Down