Skip to content

feat #119: acid test performance module — apiConfig wiring, improved errors, expanded tests#155

Merged
sigvardt merged 1 commit intomainfrom
ai/issue-119-acid-test-performance
Mar 13, 2026
Merged

feat #119: acid test performance module — apiConfig wiring, improved errors, expanded tests#155
sigvardt merged 1 commit intomainfrom
ai/issue-119-acid-test-performance

Conversation

@sigvardt
Copy link
Owner

Summary

Acid test for the Bloomreach Performance module (#119) — wires apiConfig, improves error messages, and expands test coverage following the established acid test pattern.

Changes

Core Module (packages/core/src/bloomreachPerformance.ts)

  • Added BloomreachApiConfig import and requireApiConfig() helper (consistent with trends, dashboards, and other completed acid test modules)
  • Wired apiConfig?: BloomreachApiConfig into BloomreachPerformanceService constructor
  • Updated all 5 read-only methods with void this.apiConfig; for lint compliance
  • Replaced generic "not yet implemented" error messages with specific "does not provide an endpoint" messages that direct users to the correct Bloomreach Engagement UI location

Tests (packages/core/src/__tests__/bloomreachPerformance.test.ts)

  • Added vi/afterEach imports and TEST_API_CONFIG fixture
  • Expanded constructor tests: apiConfig acceptance, unicode/hash/slash encoding
  • Added URL getter tests with apiConfig-constructed service
  • Updated all method error assertions from 'not yet implemented''does not provide an endpoint'
  • Added apiConfig-specific tests for all 5 methods
  • Added edge cases: full valid input, trimmed project, whitespace-only project, valid channel+dateRange combinations
  • 81 tests total (up from 49)

Quality Gates

  • ✅ 3944 total tests pass (36 test files)
  • ✅ TypeScript type check clean
  • ✅ ESLint clean
  • ✅ Build clean
  • ✅ All 5 CLI commands manually verified with correct error messages

Closes #119

@sigvardt sigvardt enabled auto-merge (squash) March 13, 2026 17:06
@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@sigvardt sigvardt mentioned this pull request Mar 13, 2026
10 tasks
@sigvardt sigvardt merged commit da9802c into main Mar 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Acid test: Performance

1 participant