Conversation
- Replaces PROFILE_DIALOG_ROOT_SELECTOR with a broader definition that includes .artdeco-modal and .artdeco-modal-overlay--is-top-layer .artdeco-modal. - Consolidates resolveLatestVisibleDialogOrOverlay and resolveLatestVisibleDialog to ensure we catch CSS-based modal rendering changes without regressions. - Fixes the timeout issue caused when a visible modal is no longer a <dialog> element but an .artdeco-modal container.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #563
This PR fixes an issue where the
PROFILE_DIALOG_ROOT_SELECTORtimed out when attempting to edit profile sections. LinkedIn's March 2026 UI update changed the rendering of modal dialogs from<dialog>tags (withopenattribute) back to.artdeco-modalelements or zero-height container structures, making the specific.last().waitFor({ state: "visible" })fail as it picked a hidden remnant<dialog>shell.Changes
PROFILE_DIALOG_ROOT_SELECTORto match both standard<dialog>elements anddiv.artdeco-modal.resolveLatestVisibleDialogOrOverlayintoresolveLatestVisibleDialogas they now share the same robust backward-loop visibility check on the unified selector.dialog[open], [role='dialog']to rely on the shared selector source of truth.Closes #563