Conversation
This resolves an issue where the search results scraper was targeting the `innerText` or `textContent` of the whole card wrapper for group names and member counts, resulting in over-extracted fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #593
The scraper for group search was extracting the entire text block of the search result card for the
nameandmember_countproperties. This was because it fell back to.innerTexton the card ortextContenton theapp-aware-linkwhich often wraps the entire group search result card in LinkedIn's modern UI.This PR fixes this behavior by targeting specific
h3andspanselectors that explicitly contain the name and member count before falling back to less precise methods.Changes
legacyCardsgroup search extractor to first attempt specifich3andspanselectors for name.legacyCardsgroup search extractor to attempt specificspanelements for member count before falling back.extractAiCardsand the general list fallback logic to also prioritize explicit.querySelectorAll("span")andh3tags.Validation
groups.e2e.test.tsto ensuresearchGroupsoutput remains intact.tsc -b packages/coresuccessfully to ensure type safety.Closes #593