Skip to content

fix: groups join fails due to timeout or broken selector (#594)#604

Merged
sigvardt merged 1 commit intomainfrom
ai/issue-594-bug-groups-join-fails-due-to-timeout-or-broken-sel
Mar 21, 2026
Merged

fix: groups join fails due to timeout or broken selector (#594)#604
sigvardt merged 1 commit intomainfrom
ai/issue-594-bug-groups-join-fails-due-to-timeout-or-broken-sel

Conversation

@sigvardt
Copy link
Owner

Summary

Fixes #594

Changes

  • Updated joinRegex to match both "Join" and "Request to join", along with Danish translations.
  • Added a pre-flight check to see if the Join button is visible before attempting to click. If not, it checks whether the user is already joined or has already requested to join and returns successfully if so, otherwise it throws a clear UI_CHANGED_SELECTOR_FAILED error.
  • Updated waitForCondition to explicitly watch for any dialog surface appearing (e.g. questions or additional confirmation modals).
  • If a dialog appears, it attempts to dismiss it (to avoid state bleeding) and then throws an ACTION_PRECONDITION_FAILED explaining that questions/confirmation is required to join.

Closes #594

@sigvardt sigvardt enabled auto-merge (squash) March 21, 2026 19:00
@sigvardt sigvardt merged commit 75e7b71 into main Mar 21, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: groups join fails due to timeout or broken selector

1 participant