Skip to content

feat: add robust profile banner upload/remove management (#614)#616

Merged
github-actions[bot] merged 3 commits intomainfrom
ai/issue-614-cover-imagebanner-make-it-production-grade
Mar 24, 2026
Merged

feat: add robust profile banner upload/remove management (#614)#616
github-actions[bot] merged 3 commits intomainfrom
ai/issue-614-cover-imagebanner-make-it-production-grade

Conversation

@sigvardt
Copy link
Copy Markdown
Owner

Summary

This PR implements full banner/cover image management as requested in #614.

Changes

  • Remove Banner Support: Added REMOVE_PROFILE_BANNER_ACTION_TYPE, prepareRemoveBanner, and RemoveProfileBannerActionExecutor.
  • Delete Dialog Handling: clickDeleteInDialog handles the entire delete flow including the confirmation prompt.
  • Improved Banner Error Handling: Implemented a local check for dimensions using image-size (must be at least 1584x396) and enforced an 8MB file size limit for prepareUploadBanner.
  • MCP and CLI Integration: Updated the CLI (prepare-remove-banner) and the MCP toolkit (linkedin.profile.prepare_remove_banner).
  • Tests: Created E2E test in profile.e2e.test.ts and mcp.e2e.test.ts to verify the remove preview generation and end-to-end integration.

Closes #614

@github-actions github-actions bot force-pushed the ai/issue-614-cover-imagebanner-make-it-production-grade branch from 8aa4d64 to d98a1c8 Compare March 23, 2026 20:38
@github-actions
Copy link
Copy Markdown

⚠️ Auto-rebase failed due to merge conflicts. Issue #614 relabeled for the orchestrator to resolve conflicts on this branch.

- Implement prepareRemoveBanner and RemoveProfileBannerActionExecutor
- Add banner file size and dimension checks locally
- Update CLI and MCP commands
- Add unit/E2E tests for banner operations
@sigvardt sigvardt force-pushed the ai/issue-614-cover-imagebanner-make-it-production-grade branch from d98a1c8 to 33aaff9 Compare March 23, 2026 21:28
@github-actions github-actions bot enabled auto-merge (squash) March 24, 2026 17:01
@github-actions
Copy link
Copy Markdown

🤖 Auto-merge enabled (squash). Will merge when all required checks pass.

@github-actions
Copy link
Copy Markdown

⛔ Auto-merge blocked: This PR modifies `.github/workflows/` files. AI PRs are not allowed to change workflow files. A human must review and merge this PR manually.

@github-actions github-actions bot merged commit caf3a3a into main Mar 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cover image/banner: make it production-grade

1 participant