Commit c3eb27f
committed
minor symfony#61140 [Config] Fix GeneratedConfigTest not being able to generate snapshots anymore (KevinVanSonsbeek)
This PR was merged into the 7.2 branch.
Discussion
----------
[Config] Fix GeneratedConfigTest not being able to generate snapshots anymore
| Q | A
| ------------- | ---
| Branch? | 7.2
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Issues | Fix symfony#61139
| License | MIT
PR symfony#57614 Removed multiple uses of `uniqid`. In the specific PR changes were made to the GeneratedConfigTest, to change how the directory was built for the config.
This inadvertedly broke the generating of snapshot files, due to the outputDir being changed to a by reference argument, and always overwriting the value to a temp dir. (While the snapshot files should not be written to a temp dir)
Commits
-------
8e8daf1 bugfix(symfony#61139): Only generate an outputDir if none is set.File tree
1 file changed
+6
-4
lines changed- src/Symfony/Component/Config/Tests/Builder
1 file changed
+6
-4
lines changedLines changed: 6 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
159 | 159 | | |
160 | 160 | | |
161 | 161 | | |
162 | | - | |
163 | | - | |
164 | | - | |
165 | | - | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
166 | 168 | | |
167 | 169 | | |
168 | 170 | | |
| |||
0 commit comments