Skip to content

Use shortened names and enable benchmarks on trunk. #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jdmarshall wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −5
Open

Use shortened names and enable benchmarks on trunk. #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e43248b
Use shortened names and enable benchmarks on trunk.
jdmarshall Dec 22, 2025
71020dd
Upgrade to get better jitter analysis.
jdmarshall Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ project adheres to [Semantic Versioning](http://semver.org/).
- ci: switch out deprecated benchmark-regression library for replacement
- AggregatorRegistry renamed to ClusterRegistry, old name deprecated
- chore: update faceoff to 1.1
- ci: Run additional benchmarks against trunk

### Added

Expand Down
6 changes: 3 additions & 3 deletions benchmarks/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ const debug = require('debug')('benchmark');
*/

const benchmarks = new Benchmark({
'prom-client@latest': 'prom-client@latest',
'prom-client@trunk': 'git@github.com:siimon/prom-client',
'prom-client@current': { location: process.cwd() },
released: 'prom-client@latest',
trunk: 'git@github.com:siimon/prom-client',
current: { location: process.cwd() },
});

benchmarks.suite('counter', require('./counter'));
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ const Path = require('path');
module.exports = setupUtilSuite;

function setupUtilSuite(suite) {
const skip = ['prom-client@latest', 'prom-client@trunk'];
const skip = ['released'];

suite.add(
'hashObject',
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"eslint-plugin-n": "^17.20.0",
"eslint-plugin-prettier": "^5.0.1",
"express": "^5.1.0",
"faceoff": "^1.1.0",
"faceoff": "~1.3.1",
"globals": "^16.2.0",
"husky": "^9.0.0",
"jest": "^30.0.2",
Expand Down