-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add IMessageSearchService and MessageSearchService for message … #518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SIkebe
wants to merge
3
commits into
main
Choose a base branch
from
code-scanning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| namespace RazorPagesProject.Options; | ||
|
|
||
| public class LogReaderOptions | ||
| { | ||
| public required string BaseDirectory { get; set; } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace RazorPagesProject.Services; | ||
|
|
||
| public interface ILogFileReader | ||
| { | ||
| Task<string> ReadAsync(string fileName, CancellationToken cancellationToken = default); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| using RazorPagesProject.Data; | ||
|
|
||
| namespace RazorPagesProject.Services; | ||
|
|
||
| public interface IMessageSearchService | ||
| { | ||
| Task<IReadOnlyList<Message>> SearchAsync(string term); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| using System.IO; | ||
| using System.Threading; | ||
| using System.Threading.Tasks; | ||
| using Microsoft.Extensions.Options; | ||
| using RazorPagesProject.Options; | ||
|
|
||
| namespace RazorPagesProject.Services; | ||
|
|
||
| public class LogFileReader : ILogFileReader | ||
| { | ||
| private readonly IOptions<LogReaderOptions> options; | ||
|
|
||
| public LogFileReader(IOptions<LogReaderOptions> options) | ||
| { | ||
| this.options = options; | ||
| } | ||
|
|
||
| public async Task<string> ReadAsync(string fileName, CancellationToken cancellationToken = default) | ||
| { | ||
| if (string.IsNullOrWhiteSpace(fileName)) | ||
| { | ||
| return string.Empty; | ||
| } | ||
|
|
||
| var directory = options.Value.BaseDirectory; | ||
| Directory.CreateDirectory(directory); | ||
|
|
||
| var fullPath = Path.Combine(directory, fileName); | ||
|
|
||
| if (!File.Exists(fullPath)) | ||
| { | ||
| return string.Empty; | ||
| } | ||
|
|
||
| return await File.ReadAllTextAsync(fullPath, cancellationToken); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| using Microsoft.EntityFrameworkCore; | ||
| using RazorPagesProject.Data; | ||
|
|
||
| namespace RazorPagesProject.Services; | ||
|
|
||
| public class MessageDeleteService | ||
| { | ||
| private readonly ApplicationDbContext dbContext; | ||
|
|
||
| public MessageDeleteService(ApplicationDbContext dbContext) | ||
| { | ||
| this.dbContext = dbContext; | ||
| } | ||
|
|
||
| public async Task<int> DeleteByTextAsync(string text) | ||
| { | ||
| var sql = $"DELETE FROM Messages WHERE Text = '{text}'"; | ||
| return await dbContext.Database.ExecuteSqlRawAsync(sql); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,30 @@ | ||||||||||||||||
| using System; | ||||||||||||||||
| using Microsoft.EntityFrameworkCore; | ||||||||||||||||
| using RazorPagesProject.Data; | ||||||||||||||||
|
|
||||||||||||||||
| namespace RazorPagesProject.Services; | ||||||||||||||||
|
|
||||||||||||||||
| public class MessageSearchService : IMessageSearchService | ||||||||||||||||
| { | ||||||||||||||||
| private readonly ApplicationDbContext dbContext; | ||||||||||||||||
|
|
||||||||||||||||
| public MessageSearchService(ApplicationDbContext dbContext) | ||||||||||||||||
| { | ||||||||||||||||
| this.dbContext = dbContext; | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| public async Task<IReadOnlyList<Message>> SearchAsync(string term) | ||||||||||||||||
| { | ||||||||||||||||
| if (string.IsNullOrWhiteSpace(term)) | ||||||||||||||||
| { | ||||||||||||||||
| return Array.Empty<Message>(); | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| var sql = $"SELECT Id, Text FROM Messages WHERE Text LIKE '%{term}%'"; | ||||||||||||||||
|
|
||||||||||||||||
| return await dbContext.Messages | ||||||||||||||||
| .FromSqlRaw(sql) | ||||||||||||||||
|
Comment on lines
+23
to
+26
|
||||||||||||||||
| var sql = $"SELECT Id, Text FROM Messages WHERE Text LIKE '%{term}%'"; | |
| return await dbContext.Messages | |
| .FromSqlRaw(sql) | |
| // Use parameterized query with EF.Functions.Like to prevent SQL injection | |
| return await dbContext.Messages | |
| .Where(m => EF.Functions.Like(m.Text, $"%{term}%")) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
using System;directive is unnecessary since no System namespace types are directly used in this file. TheArray.Empty<Message>()call can be replaced with[]in C# 12 ornew List<Message>()to remove this dependency.