Skip to content

Conversation

@sile
Copy link
Owner

@sile sile commented Sep 6, 2025

No description provided.

@sile sile requested a review from Copilot September 6, 2025 05:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the external byteorder dependency and replaces it with custom built-in byte order methods. The change implements custom ReadExt and WriteExt traits that provide big-endian byte reading and writing methods using Rust's built-in from_be_bytes() and to_be_bytes() functions.

  • Removes the byteorder crate dependency from Cargo.toml
  • Replaces all byteorder::BigEndian method calls with custom trait methods
  • Adds new ReadExt and WriteExt traits with big-endian byte conversion methods

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/codec.rs Removes byteorder imports, updates all read/write calls to use custom methods, and implements new ReadExt/WriteExt traits
Cargo.toml Removes byteorder dependency

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@sile sile merged commit e9f451b into master Sep 6, 2025
9 checks passed
@sile sile deleted the remove-byteorder branch September 6, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant