update NX and make it publish dependent packages on changes#77
update NX and make it publish dependent packages on changes#77andrew-polk merged 1 commit intomainfrom
Conversation
nabalone
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, all discussions resolved
package.json line 36 at r1 (raw file):
"eslint-plugin-react": "^7.37.2", "eslint-plugin-react-hooks": "^5.0.0", "nx": "20.4.6",
We have to use nx 20 for the updateDependents parameter to work correctly
nx.json line 66 at r1 (raw file):
] }, "useLegacyCache": true
added by nx's upgrade migration
.gitignore line 9 at r1 (raw file):
**/vite.config.{js,ts,mjs,mts,cjs,cts}.timestamp* **/vitest.config.{js,ts,mjs,mts,cjs,cts}.timestamp*
moved below by nx's upgrade migration and I thought we might as well just stay synced with their provided/suggested .gitignore
andrew-polk
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nabalone)
nx.json line 66 at r1 (raw file):
Previously, nabalone (Noel) wrote…
added by nx's upgrade migration
Reading (very briefly) on this, we will have to stop using it with nx 21 anyway, and the new way is better. I'm guessing they just added it for the migration to be safe. Did you try without it?
a02ac0b to
58c6ce3
Compare
nabalone
left a comment
There was a problem hiding this comment.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @andrew-polk)
nx.json line 66 at r1 (raw file):
Previously, andrew-polk wrote…
Reading (very briefly) on this, we will have to stop using it with nx 21 anyway, and the new way is better. I'm guessing they just added it for the migration to be safe. Did you try without it?
Done. Looks like it works no problem this way
andrew-polk
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nabalone)
For example, if we make changes that trigger a new release of the find-language package, this will cause an automatic new release of language-chooser-react-mui that uses the new version of find-language.
This change is