Skip to content

update NX and make it publish dependent packages on changes#77

Merged
andrew-polk merged 1 commit intomainfrom
publish_dependent_packages
Mar 5, 2025
Merged

update NX and make it publish dependent packages on changes#77
andrew-polk merged 1 commit intomainfrom
publish_dependent_packages

Conversation

@nabalone
Copy link
Collaborator

@nabalone nabalone commented Mar 5, 2025

For example, if we make changes that trigger a new release of the find-language package, this will cause an automatic new release of language-chooser-react-mui that uses the new version of find-language.


This change is Reviewable

Copy link
Collaborator Author

@nabalone nabalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 4 files reviewed, all discussions resolved


package.json line 36 at r1 (raw file):

    "eslint-plugin-react": "^7.37.2",
    "eslint-plugin-react-hooks": "^5.0.0",
    "nx": "20.4.6",

We have to use nx 20 for the updateDependents parameter to work correctly


nx.json line 66 at r1 (raw file):

    ]
  },
  "useLegacyCache": true

added by nx's upgrade migration


.gitignore line 9 at r1 (raw file):

**/vite.config.{js,ts,mjs,mts,cjs,cts}.timestamp*
**/vitest.config.{js,ts,mjs,mts,cjs,cts}.timestamp*

moved below by nx's upgrade migration and I thought we might as well just stay synced with their provided/suggested .gitignore

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nabalone)


nx.json line 66 at r1 (raw file):

Previously, nabalone (Noel) wrote…

added by nx's upgrade migration

Reading (very briefly) on this, we will have to stop using it with nx 21 anyway, and the new way is better. I'm guessing they just added it for the migration to be safe. Did you try without it?

@nabalone nabalone force-pushed the publish_dependent_packages branch from a02ac0b to 58c6ce3 Compare March 5, 2025 18:03
Copy link
Collaborator Author

@nabalone nabalone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @andrew-polk)


nx.json line 66 at r1 (raw file):

Previously, andrew-polk wrote…

Reading (very briefly) on this, we will have to stop using it with nx 21 anyway, and the new way is better. I'm guessing they just added it for the migration to be safe. Did you try without it?

Done. Looks like it works no problem this way

Copy link
Contributor

@andrew-polk andrew-polk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nabalone)

@andrew-polk andrew-polk merged commit f91f20a into main Mar 5, 2025
2 checks passed
@andrew-polk andrew-polk deleted the publish_dependent_packages branch March 5, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants