Skip to content

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 15, 2025

Alternative to #4062

Triggered by login
Uses Request.Headers.AcceptLanguage to infer UI language when not explicitly set by the user...
Thus, can return languages that we don't actually have available, which can be mapped to English in analytics processing
Also, doesn't track when the user changes UI language until the next time they log in


This change is Reviewable

@imnasnainaec imnasnainaec self-assigned this Dec 15, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 15, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch otel-ui-lang

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@imnasnainaec imnasnainaec changed the title [otel] Log UI language in backend [otel] Log UI language from the backend Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.47%. Comparing base (82bee05) to head (c1be9b1).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
Backend/Controllers/UserController.cs 14.28% 11 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4063       +/-   ##
===========================================
+ Coverage   74.59%   85.47%   +10.87%     
===========================================
  Files         294       54      -240     
  Lines       10908     4778     -6130     
  Branches     1367      591      -776     
===========================================
- Hits         8137     4084     -4053     
+ Misses       2375      550     -1825     
+ Partials      396      144      -252     
Flag Coverage Δ
backend 85.47% <14.28%> (-0.20%) ⬇️
frontend ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@imnasnainaec
Copy link
Collaborator Author

#4062 preferred

@imnasnainaec imnasnainaec deleted the otel-ui-lang branch December 19, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants