Skip to content

Fix installer grab of current user#4105

Merged
imnasnainaec merged 1 commit intomasterfrom
bugfix/installer
Jan 23, 2026
Merged

Fix installer grab of current user#4105
imnasnainaec merged 1 commit intomasterfrom
bugfix/installer

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jan 23, 2026

This change is Reviewable

Summary by CodeRabbit

Bug Fixes

  • Fixed installation script to correctly identify and apply the current system user during deployment setup, preventing issues with undefined environment variables.

✏️ Tip: You can customize this high-level summary in your review settings.

@imnasnainaec imnasnainaec self-assigned this Jan 23, 2026
@imnasnainaec imnasnainaec added the 🟥High High-priority PR: please review this asap! label Jan 23, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

📝 Walkthrough

Walkthrough

A shell script installer was updated to use command substitution $(whoami) instead of variable expansion ${whoami} when passing the current username to Ansible extra-vars. This ensures the actual username is captured at runtime rather than attempting to expand a potentially unset environment variable.

Changes

Cohort / File(s) Summary
Shell Script Configuration
deploy/scripts/install-combine.sh
Changed EXTRA_VARS from ${whoami} to $(whoami) to properly capture the current username via command substitution at runtime, fixing incorrect variable expansion syntax.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A tiny script correction, swift and clean,
From curly braces to backticks—a modest scene,
Where whoami now whispers truth at last,
No phantom variables from the past! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and clearly describes the main change: fixing how the installer retrieves the current user, which aligns with the actual code change (replacing ${whoami} with $(whoami)).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.92%. Comparing base (44f4785) to head (7d34357).
⚠️ Report is 51 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4105   +/-   ##
=======================================
  Coverage   74.92%   74.92%           
=======================================
  Files         295      295           
  Lines       10911    10911           
  Branches     1366     1366           
=======================================
  Hits         8175     8175           
  Misses       2341     2341           
  Partials      395      395           
Flag Coverage Δ
backend 86.46% <ø> (ø)
frontend 66.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec).

@imnasnainaec imnasnainaec merged commit 297591d into master Jan 23, 2026
20 checks passed
@imnasnainaec imnasnainaec deleted the bugfix/installer branch January 23, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bash deployment 🟥High High-priority PR: please review this asap!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants