Skip to content

[gha] Expand installer upload trigger#4131

Merged
imnasnainaec merged 1 commit intomasterfrom
installer-upload-triggers
Feb 2, 2026
Merged

[gha] Expand installer upload trigger#4131
imnasnainaec merged 1 commit intomasterfrom
installer-upload-triggers

Conversation

@imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Feb 2, 2026

This change is Reviewable

Summary by CodeRabbit

  • Bug Fixes

    • Corrected installer uninstall script execution path.
  • Chores

    • Enhanced installer change detection in CI/CD workflows for broader file coverage.
    • Improved code formatting in workflow definitions.

@imnasnainaec imnasnainaec self-assigned this Feb 2, 2026
@imnasnainaec imnasnainaec added the 🟨Medium Medium-priority PR label Feb 2, 2026
@github-actions github-actions bot added deployment github_actions Pull requests that update GitHub Actions code bash labels Feb 2, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 2, 2026

📝 Walkthrough

Walkthrough

Updates the installer workflow to broaden file-path triggers for change detection to include all shell and YAML files under deploy, fixes logical condition spacing, and corrects the uninstall script invocation path from a non-existent to the proper .sh file extension.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/installer.yml
Broadens change-detection triggers from specific install-combine script to all shell and YAML files in deploy directory; consolidates path patterns into a variable; fixes spacing around boolean operators in "Detect changes to installer scripts" and "Download net-installer artifact" steps.
Install Script
deploy/scripts/install-combine.sh
Corrects uninstall step to invoke the properly-named script file by adding .sh extension to ${DEPLOY_DIR}/scripts/uninstall-combine.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested labels

github_actions, bash

Suggested reviewers

  • jasonleenaylor
  • myieye

Poem

🐰 A workflow so wise, now with triggers so broad,
Deploy scripts detected along the whole road!
The uninstall.sh path, now correctly named,
With spacing so perfect, the logic proclaimed.
Hop hop to success, the installer's aflame! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Expand installer upload trigger' accurately describes the main change in the PR, which broadens the file-path triggers in the installer workflow from specific scripts to include all shell and YAML files under deploy.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch installer-upload-triggers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.73%. Comparing base (95b3acc) to head (57d877a).
⚠️ Report is 39 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4131   +/-   ##
=======================================
  Coverage   74.73%   74.73%           
=======================================
  Files         296      296           
  Lines       10958    10958           
  Branches     1369     1369           
=======================================
  Hits         8190     8190           
  Misses       2373     2373           
  Partials      395      395           
Flag Coverage Δ
backend 86.54% <ø> (ø)
frontend 65.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor partially reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec).

@imnasnainaec imnasnainaec merged commit d5ef16e into master Feb 2, 2026
23 checks passed
@imnasnainaec imnasnainaec deleted the installer-upload-triggers branch February 2, 2026 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bash deployment github_actions Pull requests that update GitHub Actions code 🟨Medium Medium-priority PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants