Conversation
📝 WalkthroughWalkthroughUpdates Helm chart configurations by changing ConfigMap environment variables to reference top-level values instead of global values and converting a static Secret resource name to a dynamic templated reference. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4188 +/- ##
=======================================
Coverage 75.15% 75.15%
=======================================
Files 302 302
Lines 11099 11099
Branches 1394 1394
=======================================
Hits 8341 8341
Misses 2357 2357
Partials 401 401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jasonleenaylor
left a comment
There was a problem hiding this comment.
@jasonleenaylor reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on imnasnainaec).
Backend is broken in new deployments with Rancher. These didn't cause a problem in existing QA and production deployments because the correct environment variables were either grandfathered in or added manually.
3 backend values were being looked for in
global, but were defined outsideglobalin https://github.com/sillsdev/TheCombine/blob/master/deploy/helm/thecombine/charts/backend/values.yaml.This change is
Summary by CodeRabbit