Docker cypress #175
Closed
Docker cypress #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces Docker Compose support for running Cypress component tests in a containerized environment. The implementation enables headless test execution with proper service orchestration and health checks.
Key Changes:
- Added Docker Compose configuration with separate containers for the Vite dev server and Cypress tests
- Created Dockerfiles for both the application service and Cypress test runner
- Modified Vite configuration to improve optimization caching during test runs
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
src/renderer/docker-compose.yml |
Defines two services (app and cypress) with health checks, volume mounts, and network configuration for running Cypress tests against a Dockerized Vite dev server |
src/renderer/Dockerfile |
Multi-stage setup for the Vite development server, installing both root and renderer dependencies with proper build context |
src/renderer/Dockerfile.cypress |
Cypress container configuration based on cypress/included:15.7.1 with necessary dependencies |
src/renderer/package.json |
Adds three new npm scripts for Docker-based Cypress testing (cy:docker, cy:docker:build, cy:docker:down) and includes the write dependency |
src/renderer/package-lock.json |
Adds dependency entries for write package and its transitive dependencies |
src/renderer/vite.config.ts |
Removes force optimization setting by adding empty optimizeDeps configuration to allow Vite to cache optimizations |
.github/workflows/dev.yml |
Integrates Docker-based Cypress tests into CI pipeline with Docker Buildx setup and proper cleanup steps |
Files not reviewed (1)
- src/renderer/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- launchs a custom version of the dev server with the latest packages for vite testing - sets the vite optimize deps so it is not run during tests - tests are run in a docker instance - user needs to be added to a docker group so sudo is note required - write was added to packages.json to support running stamp - npm run cy:docker:build - sets up containers ... reloads dependencies - npm run cy:docker - runs tests each time - npm run cy:docker:down - removes containers and network add docker cypress tests to github actions add docker-compose add docker clean up aggressive agent clean up for docker add copilot suggestions change group and user name change group and user id remove user change separate cypress tests into their own job docker w/o root deps
gtryus
force-pushed
the
docker-cypress
branch
from
3a67f60 to
2bcc664
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.